-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the return value of session_type #207
Conversation
Reviewer's Guide by SourceryThis pull request modifies the No sequence diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @odkhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a brief explanation in the PR description about why returning just the name of the submission type is preferable to the previous format that included duration.
- The PR checklist mentions adding tests, but none seem to be included. Please add appropriate tests to cover this change or update the checklist if tests are not necessary.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -676,12 +676,8 @@ def build_data(self, all_talks=False, filter_updated=None, all_rooms=False): | |||
), | |||
"do_not_record": talk.submission.do_not_record, | |||
"tags": talk.submission.get_tag(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Clarify the naming of the 'tags' field
The 'tags' field is populated by a method called 'get_tag()' (singular). This mismatch between plural and singular forms could be confusing. Consider either renaming the field to 'tag' if it's always a single tag, or ensure that 'get_tag()' returns a list of tags if multiple tags are possible.
"tags": talk.submission.get_tags(),
This PR support filter by user language in video component make by this PR: fossasia/eventyay-video#239
return object with multiple language instead of string value.
How has this been tested?
Checklist
Summary by Sourcery
Update the 'session_type' return value in the schedule model to return only the submission type name, simplifying the data structure.
Enhancements: