Added Subtitle Track selector #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimGels
force-pushed
the
audio-subtitle-track-selector
branch
from
4c24b26 to
0941b9c
Compare
TimGels
force-pushed
the
audio-subtitle-track-selector
branch
3 times, most recently
from
80dfb78 to
851c099
Compare
OneDrive-Cloud-Player/Exceptions/ServiceNotInitializedException.cs
Outdated
Show resolved
Hide resolved
TimGels
force-pushed
the
audio-subtitle-track-selector
branch
from
b482f5d to
3f4a80e
Compare
TimGels
commented
Mar 13, 2023
|
Still need to see about the user option change (removed, renamed?) |
Whatever we may decide on should be changed/ updated accordingly. Posting this here so we don't forget. |
TimGels
force-pushed
the
audio-subtitle-track-selector
branch
2 times, most recently
from
3153c0d to
bfc342e
Compare
TimGels
force-pushed
the
audio-subtitle-track-selector
branch
from
bfc342e to
e19ef3e
Compare
|
Could you test these changes again on your system @JohannesKauffmann? I added a couple more test media files to the test account for us to use. |
I decided to keep the original setting functionality intact. This needs to be tested by another set of eyes as well if possible. |
|
Other than my comment, the changes since last review look fine to me. |
TimGels
force-pushed
the
audio-subtitle-track-selector
branch
from
de022ec to
686df89
Compare
Implemented the ability to select a subtitle track on the video player page. Added a SubtitleAudioTrackSelector UserControl. This UserControl hosts the subtitle tracks and will also host the audio tracks from which a user can select a track. Introduced a MediaTrackService which can be injected to provider some methods. Methods it provide are at this moment the retrieval of subtitle tracks and the preferred subtitle track. Due to LibVLC not being able to be injected by a dependency injector due to several reasons, this service needs to be initialized by calling the initialize method and providing it with a reference to a (initialized!) MediaPlayer instance. This service can be expanded to perform more general MediaPlayer tasks as well in the future if need be. Added a ValueConverterGroup enabling the chaining of value converters. Added a custom exception which gets thrown when one of the the MediaTrackService methods get called without the service being initialized. Added MediaTrackService to the dependency Injector container in App.xaml.cs. Replaced public mediaplayer property calls with private.
TimGels
force-pushed
the
audio-subtitle-track-selector
branch
from
686df89 to
5ae0be5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the ability to select a subtitle track on the video player page.
Added a SubtitleAudioTrackSelector UserControl. This UserControl hosts the subtitle tracks and will also host the audio tracks from which a user can select a track.
Introduced a MediaTrackService which can be injected to provide some methods. Methods it provide are at this moment the retrieval of subtitle tracks and the preferred subtitle track. Due to LibVLC not being able to be injected by a dependency injector due to several reasons, this service needs to be initialized by calling the initialize method and providing it with a reference to a (initialized!) MediaPlayer instance. This service can be expanded to perform more general MediaPlayer tasks as well in the future if need be.
Added a ValueConverterGroup enabling the chaining of value converters.
Added a custom exception which gets thrown when one of the the MediaTrackService methods get called without the service being initialized.
Added MediaTrackService to the dependency Injector container in App.xaml.cs.
resolves #86