Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude query string from path_info #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cubiclabs
Copy link

The current regex for path_info includes the query string if one is present.

path_info should not include the query string and the regex tweak excludes it.

path_info should not include the query string
@pfreitag
Copy link
Member

Doesn't $uri exclude the query string? https://stackoverflow.com/questions/48708361/nginx-request-uri-vs-uri

@cubiclabs
Copy link
Author

Looking at the docs it says that the value of $uri can change during the request:
https://nginx.org/en/docs/http/ngx_http_core_module.html#uri

For context, I am using Nginx v 1.22.1 and I have some rewrites in place that are essentially the same as the ColdBox one here:
https://coldbox.ortusbooks.com/the-basics/routing/requirements/rewrite-rules#nginx

I wonder if this is affecting things in some way causing the query string to get included in the $uri and subsequently the path_info?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants