Improve API code organization #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change requires lots of testing, especially for the offline update. |
mike-sul
reviewed
Aug 27, 2024
mike-sul
reviewed
Aug 27, 2024
detsch
force-pushed
the
detsch-improve-api-code
branch
2 times, most recently
from
4d125c2 to
b17ba80
Compare
mike-sul
reviewed
Aug 28, 2024
mike-sul
approved these changes
Aug 28, 2024
detsch
force-pushed
the
detsch-improve-api-code
branch
from
b17ba80 to
619feff
Compare
mike-sul
approved these changes
Aug 29, 2024
Main change is the addition of updateMeta function, to reduce code duplication between CheckIn and CheckInLocal, specially related to error handling. Additional methods added: checkInFailure, getBundleMeta, getRepoSource. Signed-off-by: Andre Detsch <[email protected]>
Signed-off-by: Andre Detsch <[email protected]>
Simplify one boolean expression, and adjust style of code when returning a CheckInResult instance. Signed-off-by: Andre Detsch <[email protected]>
getAvailableTargets is always called with `just_latest = false`. Remove the parameter and set the behavior to always return all available targets from the allowed_targets list. Signed-off-by: Andre Detsch <[email protected]>
detsch
force-pushed
the
detsch-improve-api-code
branch
from
619feff to
7e3a249
Compare
|
Did additional e2e testing, no problems found. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some local changes in order to better organize the api.cc code. Key objective is to simplify CheckIn* methods, moving code to separate methods when appropriate, and also reducing code duplication. There is still work to be done in that direction, but the current set of changes already represent an improvement.
@mike-sul I still need to give it some additional testing, but it should be ready for review.