-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report which apps require update in DownloadStarted event #357
Conversation
@detsch This is the nice idea, thanks for doing it. |
29201e6
to
4ce9c58
Compare
I've updated the internal structure used to store the apps and reasons from vector to map, so the format is fully applied when building the reason string, not concatenating app name and reason before that. |
@mike-sul I've taken a look into adding apps to update + reasons to the "update to target N+1" event, but it is not as trivial as this PR. We currently send the |
No need to worry about it. It is not so important for the regular update case (N to N+1 update). |
This affects aklite CLI pull, install, and update commands. Signed-off-by: Andre Detsch <[email protected]>
4ce9c58
to
91d67d8
Compare
Adds additional information to the DownloadStarted event detailing the reasons for an Apps Sync update to be initiated. Signed-off-by: Andre Detsch <[email protected]>
91d67d8
to
05b018d
Compare
This is what the DonwloadStarted event details look like for an "apps sync" update operation:
(updated the above example after the latest force push)
I've started by only adding the app name, but decided to go a little further by adding the specific reason as well, so I created a new patch on top of the original implementation.