Set upload data size explicitly

.clang-tidy

@@ -1,102 +1,59 @@
 ---
-Checks:          'clang-analyzer-*, performance-*,readability-*,-readability-else-after-return,-readability-identifier-naming,-readability-container-size-empty,-readability-redundant-declaration,modernize-*,-modernize-avoid-bind,-modernize-loop-convert,-modernize-use-using,-modernize-deprecated-headers, llvm-namespace-comment,cppcoreguidelines-pro-*,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,cert-*,-cert-err58-cpp,-cert-env33-c,-cert-err09-cpp,-cert-err60-cpp,-cert-err61-cpp, -cert-err61-cpp, bugprone-*, google-*,-google-runtime-references,-google-runtime-member-string-references, -google-explicit-constructor, -google-readability-todo, misc-*, -misc-unused-parameters, -misc-macro-parentheses, -misc-throw-by-value-catch-by-reference, -misc-suspicious-enum-usage'
+Checks:          >-
+  boost-*,
+  bugprone-*,
+  cert-*,-cert-err58-cpp,-cert-env33-c,-cert-err60-cpp,
+  clang-analyzer-*,
+  cppcoreguidelines-*,-cppcoreguidelines-avoid-magic-numbers,-cppcoreguidelines-init-variables,-cppcoreguidelines-owning-memory,-cppcoreguidelines-non-private-member-variables-in-classes,-cppcoreguidelines-macro-usage,
+  cppcoreguidelines-pro-*,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+  google-*,-google-runtime-references,-google-readability-todo,
+  hicpp-*,-hicpp-no-array-decay,-hicpp-no-assembler,-hicpp-signed-bitwise,-hicpp-vararg,
+  llvm-namespace-comment,
+  misc-*,-misc-non-private-member-variables-in-classes,
+  modernize-*,-modernize-avoid-bind,-modernize-loop-convert,-modernize-use-trailing-return-type,
+  performance-*,
+  readability-*,-readability-else-after-return,-readability-identifier-naming,-readability-magic-numbers,-readability-function-cognitive-complexity,
+  -modernize-use-nodiscard,
+
 WarningsAsErrors: '*'
 AnalyzeTemporaryDtors: false
-CheckOptions:    
+CheckOptions:
   - key:             cert-dcl59-cpp.HeaderFileExtensions
-    value:           h,hh,hpp,hxx
+    value:           h
   - key:             cert-err09-cpp.CheckThrowTemporaries
     value:           '1'
   - key:             cert-err61-cpp.CheckThrowTemporaries
     value:           '1'
-  - key:             cert-oop11-cpp.IncludeStyle
-    value:           llvm
-  - key:             cppcoreguidelines-pro-bounds-constant-array-index.GslHeader
-    value:           ''
-  - key:             cppcoreguidelines-pro-bounds-constant-array-index.IncludeStyle
-    value:           '0'
   - key:             cppcoreguidelines-pro-type-member-init.IgnoreArrays
     value:           '0'
   - key:             google-build-namespaces.HeaderFileExtensions
-    value:           h,hh,hpp,hxx
+    value:           h
   - key:             google-global-names-in-headers.HeaderFileExtensions
     value:           h
   - key:             google-readability-braces-around-statements.ShortStatementLines
     value:           '1'
   - key:             google-readability-function-size.BranchThreshold
-    value:           '4294967295'
+    value:           '100'
   - key:             google-readability-function-size.LineThreshold
-    value:           '4294967295'
+    value:           '1000'
   - key:             google-readability-function-size.StatementThreshold
     value:           '800'
   - key:             google-readability-namespace-comments.ShortNamespaceLines
     value:           '10'
   - key:             google-readability-namespace-comments.SpacesBeforeComments
     value:           '2'
-  - key:             google-runtime-int.SignedTypePrefix
-    value:           int
-  - key:             google-runtime-int.TypeSuffix
-    value:           ''
-  - key:             google-runtime-int.UnsignedTypePrefix
-    value:           uint
-  - key:             google-runtime-references.WhiteListTypes
-    value:           ''
   - key:             llvm-header-guard.HeaderFileExtensions
-    value:           ',h,hh,hpp,hxx'
+    value:           h
   - key:             llvm-namespace-comment.ShortNamespaceLines
-    value:           '1'
+    value:           '10'
   - key:             llvm-namespace-comment.SpacesBeforeComments
-    value:           '1'
-  - key:             misc-argument-comment.StrictMode
-    value:           '0'
-  - key:             misc-assert-side-effect.AssertMacros
-    value:           assert
-  - key:             misc-assert-side-effect.CheckFunctionCalls
-    value:           '0'
-  - key:             misc-dangling-handle.HandleClasses
-    value:           'std::basic_string_view;std::experimental::basic_string_view'
+    value:           '2'
   - key:             misc-definitions-in-headers.HeaderFileExtensions
-    value:           ',h,hh,hpp,hxx'
+    value:           h
   - key:             misc-definitions-in-headers.UseHeaderFileExtension
     value:           '1'
-  - key:             misc-misplaced-widening-cast.CheckImplicitCasts
-    value:           '1'
-  - key:             misc-move-constructor-init.IncludeStyle
-    value:           llvm
-  - key:             misc-sizeof-expression.WarnOnSizeOfCompareToConstant
-    value:           '1'
-  - key:             misc-sizeof-expression.WarnOnSizeOfConstant
-    value:           '1'
-  - key:             misc-sizeof-expression.WarnOnSizeOfThis
-    value:           '1'
-  - key:             misc-string-constructor.LargeLengthThreshold
-    value:           '8388608'
-  - key:             misc-string-constructor.WarnOnLargeLength
-    value:           '1'
-  - key:             misc-suspicious-enum-usage.StrictMode
-    value:           '0'
-  - key:             misc-suspicious-missing-comma.MaxConcatenatedTokens
-    value:           '5'
-  - key:             misc-suspicious-missing-comma.RatioThreshold
-    value:           '0.200000'
-  - key:             misc-suspicious-missing-comma.SizeThreshold
-    value:           '5'
-  - key:             misc-suspicious-string-compare.StringCompareLikeFunctions
-    value:           ''
-  - key:             misc-suspicious-string-compare.WarnOnImplicitComparison
-    value:           '1'
-  - key:             misc-suspicious-string-compare.WarnOnLogicalNotComparison
-    value:           '0'
   - key:             misc-throw-by-value-catch-by-reference.CheckThrowTemporaries
     value:           '1'
-  - key:             modernize-loop-convert.MaxCopySize
-    value:           '16'
-  - key:             modernize-loop-convert.MinConfidence
-    value:           reasonable
-  - key:             modernize-loop-convert.NamingStyle
-    value:           CamelCase
-  - key:             modernize-replace-auto-ptr.IncludeStyle
-    value:           llvm
   - key:             modernize-use-auto.RemoveStars
     value:           '0'
   - key:             modernize-use-default-member-init.UseAssignment
@@ -105,26 +62,14 @@ CheckOptions:
     value:           '::std::vector;::std::list;::std::deque'
   - key:             modernize-use-emplace.SmartPointers
     value:           '::std::shared_ptr;::std::unique_ptr;::std::auto_ptr;::std::weak_ptr'
-  - key:             modernize-use-nullptr.NullMacros
-    value:           'NULL'
-  - key:             modernize-use-transparent-functors.SafeMode
-    value:           '0'
-  - key:             performance-faster-string-find.StringLikeClasses
-    value:           'std::basic_string'
-  - key:             performance-for-range-copy.WarnOnAllAutoCopies
-    value:           '0'
   - key:             performance-inefficient-string-concatenation.StrictMode
     value:           '0'
-  - key:             performance-type-promotion-in-math-fn.IncludeStyle
-    value:           llvm
-  - key:             performance-unnecessary-value-param.IncludeStyle
-    value:           llvm
   - key:             readability-braces-around-statements.ShortStatementLines
-    value:           '0'
+    value:           '1'
   - key:             readability-function-size.BranchThreshold
-    value:           '4294967295'
+    value:           '100'
   - key:             readability-function-size.LineThreshold
-    value:           '4294967295'
+    value:           '1000'
   - key:             readability-function-size.StatementThreshold
     value:           '800'
   - key:             readability-identifier-naming.AbstractClassCase
@@ -393,9 +338,9 @@ CheckOptions:
     value:           ''
   - key:             readability-identifier-naming.VirtualMethodSuffix
     value:           ''
-  - key:             readability-implicit-bool-cast.AllowConditionalIntegerCasts
+  - key:             readability-implicit-bool-conversion.AllowConditionalIntegerCasts
     value:           '0'
-  - key:             readability-implicit-bool-cast.AllowConditionalPointerCasts
+  - key:             readability-implicit-bool-conversion.AllowConditionalPointerCasts
     value:           '0'
   - key:             readability-simplify-boolean-expr.ChainedConditionalAssignment
     value:           '0'

.github/workflows/ci.yml

@@ -0,0 +1,124 @@
+name: Aktualizr CI
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+env:
+  CCACHE_DIR: ${{ github.workspace }}/.ccache
+jobs:
+  coverage:
+    name: Coverage on Ubuntu Bionic
+    runs-on: ubuntu-latest
+    env:
+      DOCKER_TAG: docker.pkg.github.com/uptane/aktualizr/aktualizr-ci:bionic-master
+      DOCKERFILE: docker/Dockerfile.ubuntu.bionic
+      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+      DARGS: >-
+        -eCCACHE_DIR
+        -eCODECOV_TOKEN
+        -eTEST_CMAKE_BUILD_TYPE=Valgrind
+        -eTEST_WITH_COVERAGE=1
+        -eTEST_WITH_P11=1
+        -eTEST_WITH_FAULT_INJECTION=1
+        -eTEST_TESTSUITE_EXCLUDE=credentials
+        -eTEST_SOTA_PACKED_CREDENTIALS=dummy-credentials
+    steps:
+      - uses: actions/checkout@master
+        with:
+          submodules: recursive
+      - run: git fetch --prune --unshallow
+      - name: Docker login
+        if: github.token
+        run: echo ${{ github.token }} | docker login docker.pkg.github.com -u uptane --password-stdin
+      - name: Docker build
+        run: |
+          docker pull "$DOCKER_TAG" || true
+          docker build --cache-from "$DOCKER_TAG" --pull -t "$DOCKER_TAG" -f "$DOCKERFILE" .
+      - uses: actions/[email protected]
+        with:
+          path: ${{ github.workspace }}/.ccache
+          key: ubuntu-bionic-${{ github.run_id }}
+          restore-keys: |
+            ubuntu-bionic-${{ github.run_id }}
+            ubuntu-bionic-
+      - name: Test
+        run: docker run -v "$PWD:$PWD" -w "$PWD" $DARGS -t "$DOCKER_TAG" ./scripts/test.sh
+
+  nop11:
+    name: Tests without p11 support on Ubuntu Bionic
+    runs-on: ubuntu-latest
+    env:
+      DOCKER_TAG: docker.pkg.github.com/uptane/aktualizr/aktualizr-ci:bionic-master
+      DOCKERFILE: docker/Dockerfile.ubuntu.bionic
+      DARGS: >-
+        -eCCACHE_DIR
+        -eTEST_CMAKE_BUILD_TYPE=Debug
+        -eTEST_WITH_P11=0
+        -eTEST_WITH_TESTSUITE=0
+    steps:
+      - uses: actions/checkout@master
+        with:
+          submodules: recursive
+      - run: git fetch --prune --unshallow
+      - name: Docker login
+        if: github.token
+        run: echo ${{ github.token }} | docker login docker.pkg.github.com -u uptane --password-stdin
+      - name: Docker build
+        run: |
+          docker pull "$DOCKER_TAG" || true
+          docker build --cache-from "$DOCKER_TAG" --pull -t "$DOCKER_TAG" -f "$DOCKERFILE" .
+      - uses: actions/[email protected]
+        with:
+          path: ${{ github.workspace }}/.ccache
+          key: ubuntu-bionic-${{ github.run_id }}
+          restore-keys: |
+            ubuntu-bionic-${{ github.run_id }}
+            ubuntu-bionic-
+      - name: Test
+        run: docker run -v "$PWD:$PWD" -w "$PWD" $DARGS -t "$DOCKER_TAG" ./scripts/test.sh
+
+  static-checks:
+    name: Static checks on Ubuntu Focal
+    runs-on: ubuntu-latest
+    env:
+      DOCKER_TAG: docker.pkg.github.com/uptane/aktualizr/aktualizr-ci:ubuntu-focal-master
+      DOCKERFILE: docker/Dockerfile.ubuntu.focal
+      DARGS: >-
+        -eCCACHE_DIR
+        -eTEST_CC=clang
+        -eTEST_CMAKE_BUILD_TYPE=Valgrind
+        -eTEST_TESTSUITE_ONLY=crypto
+        -eTEST_WITH_STATICTESTS=1
+        -eTEST_WITH_DOCS=1
+    steps:
+      - uses: actions/checkout@master
+        with:
+          submodules: recursive
+      - run: git fetch --prune --unshallow
+      - name: Docker login
+        if: github.token
+        run: echo ${{ github.token }} | docker login docker.pkg.github.com -u uptane --password-stdin
+      - name: Docker build
+        run: |
+          docker pull "$DOCKER_TAG" || true
+          docker build --cache-from "$DOCKER_TAG" --pull -t "$DOCKER_TAG" -f "$DOCKERFILE" .
+      - uses: actions/[email protected]
+        with:
+          path: ${{ github.workspace }}/.ccache
+          key: ubuntu-focal-${{ github.run_id }}
+          restore-keys: |
+            ubuntu-focal-${{ github.run_id }}
+            ubuntu-focal-
+      - name: Test
+        run: docker run -v "$PWD:$PWD" -w "$PWD" $DARGS -t "$DOCKER_TAG" ./scripts/test.sh
+
+  shellcheck:
+    name: Shellcheck
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Run ShellCheck
+      uses: ludeeus/action-shellcheck@master
+      with:
+        ignore_paths: third_party

.github/workflows/update-docker.yml

@@ -0,0 +1,36 @@
+name: Aktualizr CI docker images update
+on:
+  push:
+    branches: [ master ]
+jobs:
+  update-bionic:
+    name: Update Ubuntu Bionic Image
+    runs-on: ubuntu-latest
+    env:
+      DOCKER_TAG: docker.pkg.github.com/uptane/aktualizr/aktualizr-ci:bionic-master
+      DOCKERFILE: docker/Dockerfile.ubuntu.bionic
+    steps:
+      - uses: actions/checkout@master
+      - name: Docker login
+        run: echo ${{ github.token }} | docker login docker.pkg.github.com -u uptane --password-stdin
+      - name: Docker build and push
+        run: |
+          docker pull "$DOCKER_TAG" || true
+          docker build --cache-from "$DOCKER_TAG" --pull -t "$DOCKER_TAG" -f "$DOCKERFILE" .
+          docker push "$DOCKER_TAG"
+
+  update-ubuntu-focal:
+    name: Update Ubuntu Focal Image
+    runs-on: ubuntu-latest
+    env:
+      DOCKER_TAG: docker.pkg.github.com/uptane/aktualizr/aktualizr-ci:ubuntu-focal-master
+      DOCKERFILE: docker/Dockerfile.ubuntu.focal
+    steps:
+      - uses: actions/checkout@master
+      - name: Docker login
+        run: echo ${{ github.token }} | docker login docker.pkg.github.com -u uptane --password-stdin
+      - name: Docker build and push
+        run: |
+          docker pull "$DOCKER_TAG" || true
+          docker build --cache-from "$DOCKER_TAG" --pull -t "$DOCKER_TAG" -f "$DOCKERFILE" .
+          docker push "$DOCKER_TAG"

.gitignore

@@ -46,3 +46,5 @@ __pycache__/
 # QT Creator
 CMakeLists.txt.user
 /docs/ota-client-guide/modules/ROOT/pages/_junk
+*.code-workspace
+.vscode/launch.json

.gitmodules

@@ -1,12 +1,9 @@
 [submodule "tests/tuf-test-vectors"]
 	path = tests/tuf-test-vectors
-	url = https://github.com/advancedtelematic/tuf-test-vectors/
-[submodule "third_party/isotp-c"]
-	path = third_party/isotp-c
-	url = https://github.com/advancedtelematic/isotp-c.git
-[submodule "third_party/HdrHistogram_c"]
-	path = third_party/HdrHistogram_c
-	url = https://github.com/HdrHistogram/HdrHistogram_c
+	url = https://github.com/advancedtelematic/tuf-test-vectors.git
 [submodule "third_party/googletest"]
 	path = third_party/googletest
 	url = https://github.com/google/googletest.git
+[submodule "third_party/jsoncpp"]
+	path = third_party/jsoncpp
+	url = https://github.com/open-source-parsers/jsoncpp

.ort.yml

@@ -1,14 +1,15 @@
 excludes:
   paths:
-  - pattern: "partial/extern/**"
-    reason: "TEST_TOOL_OF"
-    comment: "This directory contains external dependencies only used by examples which are not distributed."
   - pattern: "tests/**"
     reason: "TEST_TOOL_OF"
     comment: "This directory contains tests which are not distributed."
   - pattern: "third_party/googletest/**"
     reason: "TEST_TOOL_OF"
-    comment: "This directory contains tests which are not distributed."
+    comment: "This directory contains support code for tests which are not distributed."
+  - pattern: "third_party/junit/ctest2junit.xsl"
+    reason: "TEST_TOOL_OF"
+    comment: "This file contains support code for tests which are not distributed."
   - pattern: "thirdparty.spdx"
     reason: "TEST_TOOL_OF"
     comment: "This file contains metadata which are not distributed."
+