Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Andy Doan <[email protected]>
Co-authored-by: Daiane Angolini <[email protected]>
  • Loading branch information
3 people authored Nov 9, 2023
1 parent 093aef0 commit 7fb9f5d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion source/reference-manual/docker/container-secrets.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ However, the general approach to getting these secrets securely into your contai

.. note::

There are several `insecure ways`_ that should be avoid.
There are several `insecure ways`_ that should be avoided.
The proper approach is described here based on new functionality in Docker's BuildKit.

.. _insecure ways:
Expand Down
4 changes: 2 additions & 2 deletions source/user-guide/containers-and-docker/containers.rst
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ A common case is including Git commit information into a container::
Advanced Container Dependencies
-------------------------------

On a rare occasion, a Factory will need custom code to run *before* the Docker build logic is called.
This can be done with a file in the top-level directory of ``containers.git``, ``pre-build.conf``.
On rare occasions, a Factory will need custom code to run *before* the Docker build logic is called.
This can be done by adding the file ``pre-build.conf`` in the top-level directory of ``containers.git``.

Examples
~~~~~~~~
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ In the first stage you can install dependencies for development, like a toolchai
In the final stage, the image is kept clean with just the necessities for your application.
This is done by making use of the final artifacts from the first stage.

This guide present a Dockerfile implementing a ``helloworld`` application written in C.
This guide presents a Dockerfile implementing a ``helloworld`` application written in C.

In the first example, the Dockerfile is implementing everything in a single stage, leaving all objects and spare software in the image.

Expand Down

0 comments on commit 7fb9f5d

Please sign in to comment.