Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to managing devices #600

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

kprosise
Copy link
Contributor

Updated getting-started/registering-device to include "managing" language to improve findability. Older (v73) docs had "Managing" page, redirect now goes to the getting started page. With same info.

Small style changes also applied to the page.

QA Steps: Ran linter, linkcheck, and checked html in browser.

No issues to link, small fix following Slack discussion.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Updated getting-started/registering-device to include "managing"
language to improve findability. Older (v73) docs had "Managing" page,
redirect now goes to the getting started page. With same info.

Small style changes also applied to the page.

QA Steps: Ran linter, linkcheck, and checked html in browser.

No issues to link, small fix following Slack discussion.

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise requested review from vanmaegima and a team September 19, 2023 17:09
@doanac
Copy link
Member

doanac commented Sep 19, 2023

@@ -44,5 +43,9 @@ Your Linux® microPlatform (LmP) image includes the ``lmp-device-register`` tool

.. note::

**By default**, after registration devices will run **all** applications that are available in the latest Target. This behavior can be changed by enabling only specific applications.
After registration devices will run **all** applications that are available in the latest Target.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's missing some comma or some words. After registration devices will run....

or After registering the devices, they will run all applications....

@kprosise kprosise merged commit 3b7e555 into foundriesio:main Sep 20, 2023
1 check passed
@kprosise kprosise deleted the managing-devices-findability branch January 9, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants