Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm: linux-disk-encryption: fix append order for luks #609

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

ricardosalveti
Copy link
Member

First append and then specify the target hardware, otherwise it ends up overriding the variable instead.

@ricardosalveti
Copy link
Member Author

Bug found by @ldts

First append and then specify the target hardware, otherwise it ends up
overriding the variable instead.

Signed-off-by: Ricardo Salveti <[email protected]>
@ricardosalveti ricardosalveti changed the title rf: linux-disk-encryption: fix append order for luks rm: linux-disk-encryption: fix append order for luks Oct 2, 2023
@ldts
Copy link
Contributor

ldts commented Oct 3, 2023

LGTM

Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will go ahead and merge.

@kprosise kprosise merged commit 6da9f63 into foundriesio:main Oct 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants