-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fioctl symbolic link to setup git cannot be fixed #623
Conversation
acd126c
to
13f17d1
Compare
Docs for 13f17d1 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2459/docs/artifacts/html/index.html |
13f17d1
to
37ea804
Compare
Docs for 37ea804 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2461/docs/artifacts/html/index.html |
37ea804
to
8ca5881
Compare
Docs for 8ca5881 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2462/docs/artifacts/html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, the warning box is too big. And the box's content is more like a tip than a warning (I prefer to use warning to say that a command can brick a board, for example).
I don't know how is the FAQ linking strategy we've been using (I've never made a FAQ). Let's see what @kprosise say about this.
Other this points, I'm OK with the PR, and if we decide to keep this as is I'm also OK
c65a555
to
04bca2d
Compare
Docs for 04bca2d are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2473/docs/artifacts/html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
git config --global credential.https://source.foundries.io.username fio-oauth2 | ||
git config --global credential.https://source.foundries.io.helper fio | ||
ln -s /usr/local/bin/fioctl /usr/bin/git-credential-fio | ||
* If for some reason the command fails with an error, manual steps can be taken to get the exact same result. For comprehensive instructions, please see the :ref:`Fioctl™ Errors <ref-ts-errors>` section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't like this warning (previous one) but we needed at some time when we changed to setting up git with fioctl. My idea was to remove it once fioctl git setting was stable. @camilamacedo86 did you have any issues with that and needed to run the manual steps recently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I encountered issues. They may occur depending on the environment and specific Git configurations.
The manual steps are really important. Indeed for MEDs
Note that they were here already. The problem that I am trying to address is that the current instructions say for us to create a symbolic link for a specific path (default linux one) when it might not be accurate. For example, the path in the Mac will depends on if you are using homebrew and etc.
04bca2d
to
f1a84d1
Compare
Docs for f1a84d1 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2474/docs/artifacts/html/index.html |
Signed-off-by: Camila Macedo <[email protected]>
f1a84d1
to
ff160cc
Compare
Docs for ff160cc are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2475/docs/artifacts/html/index.html |
Signed-off-by: Camila Macedo [email protected]
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.