Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fioctl symbolic link to setup git cannot be fixed #623

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

camilamacedo86
Copy link
Contributor

Signed-off-by: Camila Macedo [email protected]

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

@camilamacedo86 camilamacedo86 force-pushed the fix-git-instruction branch 2 times, most recently from acd126c to 13f17d1 Compare November 2, 2023 07:57
@doanac
Copy link
Member

doanac commented Nov 2, 2023

@doanac
Copy link
Member

doanac commented Nov 2, 2023

@doanac
Copy link
Member

doanac commented Nov 2, 2023

Copy link
Collaborator

@angolini angolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, the warning box is too big. And the box's content is more like a tip than a warning (I prefer to use warning to say that a command can brick a board, for example).

I don't know how is the FAQ linking strategy we've been using (I've never made a FAQ). Let's see what @kprosise say about this.

Other this points, I'm OK with the PR, and if we decide to keep this as is I'm also OK

source/getting-started/install-fioctl/index.rst Outdated Show resolved Hide resolved
@camilamacedo86 camilamacedo86 force-pushed the fix-git-instruction branch 2 times, most recently from c65a555 to 04bca2d Compare November 6, 2023 07:07
@doanac
Copy link
Member

doanac commented Nov 6, 2023

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Nov 6, 2023

Hi @angolini and @kprosise

I've taken care of the suggestions made now.
Please feel free to check them out.

Thank you for your attention and time.

Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

git config --global credential.https://source.foundries.io.username fio-oauth2
git config --global credential.https://source.foundries.io.helper fio
ln -s /usr/local/bin/fioctl /usr/bin/git-credential-fio
* If for some reason the command fails with an error, manual steps can be taken to get the exact same result. For comprehensive instructions, please see the :ref:`Fioctl™ Errors <ref-ts-errors>` section.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't like this warning (previous one) but we needed at some time when we changed to setting up git with fioctl. My idea was to remove it once fioctl git setting was stable. @camilamacedo86 did you have any issues with that and needed to run the manual steps recently?

Copy link
Contributor Author

@camilamacedo86 camilamacedo86 Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I encountered issues. They may occur depending on the environment and specific Git configurations.
The manual steps are really important. Indeed for MEDs

Note that they were here already. The problem that I am trying to address is that the current instructions say for us to create a symbolic link for a specific path (default linux one) when it might not be accurate. For example, the path in the Mac will depends on if you are using homebrew and etc.

source/user-guide/troubleshooting/troubleshooting.rst Outdated Show resolved Hide resolved
source/user-guide/troubleshooting/troubleshooting.rst Outdated Show resolved Hide resolved
@doanac
Copy link
Member

doanac commented Nov 6, 2023

@doanac
Copy link
Member

doanac commented Nov 6, 2023

@kprosise kprosise merged commit 411ffca into foundriesio:main Nov 8, 2023
3 checks passed
@camilamacedo86 camilamacedo86 deleted the fix-git-instruction branch November 9, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants