Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform and linux terms to glossary #720

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

kprosise
Copy link
Contributor

Additional terms added to glossary, and references added to a number of pages. A couple typos encountered fixed.

QA steps: Checked rendered output and checked with linter.

This commit addresses FFTK-3012
This commit addresses FFTK-3011
This commit applies to FFTK-2011

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

@kprosise kprosise requested review from angolini and a team June 26, 2024 11:42
@doanac
Copy link
Member

doanac commented Jun 26, 2024

@doanac
Copy link
Member

doanac commented Jun 26, 2024

@kprosise kprosise force-pushed the add-platform-glossary branch from 1192e7b to 3edf817 Compare June 26, 2024 13:48
@doanac
Copy link
Member

doanac commented Jun 26, 2024

@kprosise kprosise force-pushed the add-platform-glossary branch from 3edf817 to f9d23af Compare June 26, 2024 14:01
@doanac
Copy link
Member

doanac commented Jun 26, 2024

Copy link
Collaborator

@angolini angolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only few comments.Sorry for my delay

And thanks a lot for gathering this! <3

source/glossary/index.rst Outdated Show resolved Hide resolved
source/glossary/index.rst Outdated Show resolved Hide resolved
source/glossary/index.rst Outdated Show resolved Hide resolved
source/glossary/index.rst Outdated Show resolved Hide resolved
source/glossary/index.rst Outdated Show resolved Hide resolved
@doanac
Copy link
Member

doanac commented Jul 1, 2024

source/glossary/index.rst Outdated Show resolved Hide resolved
@doanac
Copy link
Member

doanac commented Jul 1, 2024

Additional terms added to glossary, and references added to a number of
pages. A couple typos encountered fixed.

QA steps: Checked rendered output and checked with linter.

This commit addresses FFTK-3012
This commit addresses FFTK-3011
This commit applies to FFTK-2011

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
@kprosise kprosise force-pushed the add-platform-glossary branch from f2399f0 to b704549 Compare July 1, 2024 16:06
@doanac
Copy link
Member

doanac commented Jul 1, 2024

@kprosise kprosise merged commit f287d2a into foundriesio:main Jul 1, 2024
1 of 3 checks passed
@kprosise kprosise deleted the add-platform-glossary branch July 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants