Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offline documentation #737

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

kprosise
Copy link
Contributor

Offline documentation is provided in both PDF and HTML form. As the extension used to build the PDF may come with dependency issues, it is commented out in requirements.txt. Both offline versions will be created manually as part of the release process by a technical writer and added to GitHub.

Change to the glossary page fixes an issue with linking within the PDF.the TOC on the title page shows 2 levels, which makes the PDF simpler to navigate.

QA: Checked that "Offline Version" link in footer would link to /releases/ if dev version of docs, otherwise to the release version. Checked rendered output in browser. Ran linkcheck.

This commit addresses FFTK-1785

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Offline documentation is provided in both PDF and HTML form.
As the extension used to build the PDF may come with dependency issues,
it is commented out in `requirements.txt`. Both offline versions will be
created manually as part of the release process by a technical writer
and added to GitHub.

Change to the glossary page fixes an issue with linking
within the PDF.the TOC on the title page shows 2 levels, which makes the
PDF simpler to navigate.

QA: Checked that "Offline Version" link in footer would link to
`/releases/` if dev version of docs, otherwise to the release version.
Checked rendered output in browser. Ran linkcheck.

This commit addresses FFTK-1785

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise requested review from angolini, mike-scott, vanmaegima and a team August 15, 2024 09:41
@doanac
Copy link
Member

doanac commented Aug 15, 2024

@kprosise kprosise merged commit 51c8e37 into foundriesio:main Aug 16, 2024
3 checks passed
@kprosise kprosise deleted the offline-docs branch August 16, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants