Apply new RTD theme options #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs for 81bce4d are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2729/docs/artifacts/html/index.html |
|
Looking good. I like the |
MrCry0
approved these changes
Aug 19, 2024
Applied theme changes that are configurable without modifying CSS or HTML. Deeper changes to the theme can always be investigated later. Changes of note: * "+" symbol in sidebar next to sections which can be expanded to show subsections. We may wish to investigate changing the color to increase visibility, if this is an option we want to add to the docs. * Background color of sidebar updated to match website * External links are styled, so as to indicate such. QA steps: viewed rendered html in browser, ran linkcheck. No associated issue, minor changes to test out. Signed-off-by: Katrina Prosise <[email protected]>
kprosise
force-pushed
the
refresh-theme-options
branch
from
81bce4d to
238994d
Compare
|
I changed the background color for the ToC sidebar, which makes the "+" a bit more visible. |
|
Docs for 238994d are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2730/docs/artifacts/html/index.html |
|
Linkcheck error can be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied theme changes that are configurable without modifying CSS or HTML. Deeper changes to the theme can always be investigated later.
Changes of note:
"+" symbol in sidebar next to sections which can be expanded to show subsections. We may wish to investigate changing the color to increase visibility, if this is an option we want to add to the docs.
Background color of sidebar updated to match website
External links are styled, so as to indicate such.
QA steps: viewed rendered html in browser, ran linkcheck.
No associated issue, minor changes to test out.
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
make linkcheck.-s, --signoff).-S, --gpg-sign).Comments
This is just to test out some theme options, to see if we wish to adopt any of them.