Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FoundriesFactory trademark usage #740

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

kprosise
Copy link
Contributor

Trademark should be unregistered, used as proper adjective, and after first occurrence other than in a title or header.

QA: Used linter against source, ran build and linkcheck

This commit addresses FFTK-3431

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Addresses change requested by Marketing.

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Trademark should be unregistered, used as proper adjective, and after
first occurrence other than in a title or header.

QA: Used linter against source, ran build and linkcheck

This commit addresses FFTK-3431

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise requested review from vanmaegima and a team August 23, 2024 10:37
@kprosise kprosise marked this pull request as ready for review August 23, 2024 10:40
@doanac
Copy link
Member

doanac commented Aug 23, 2024

@kprosise
Copy link
Contributor Author

Vale fails as it is triggered by unrelated errors in all files with changes, which is substantial

@kprosise kprosise merged commit d108a49 into foundriesio:main Aug 23, 2024
2 of 3 checks passed
@kprosise kprosise deleted the fix-ff-trademark-usage branch August 23, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants