Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsp: lmp-machine-custom: Use weaker assign for UBOOT_SIGN_ENABLE #1274

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

angolini
Copy link
Contributor

@angolini angolini commented Sep 4, 2023

The goal is to provide an overridable default value to the UBOOT_SIGN_ENABLE variable.

Using ??= to provide a default value for the imx generic bsp. This way, if a new machine is included in the platform, the default is defined by LmP.

Using ? = to the reference machines, so it can be overrided by an .inc or a .conf file.

To override the default value, use, for example:

UBOOT_SIGN_ENABLE:sota:mx6ulevk = "0"

@angolini
Copy link
Contributor Author

angolini commented Sep 4, 2023

@ricardosalveti
Copy link
Member

Please also extend the commit message to reflect the PR description used here.

The goal is to provide an overridable default value to the
UBOOT_SIGN_ENABLE variable.

Using ??= to provide a default value for the imx generic bsp. This way,
if a new machine is included in the platform, the default is defined by LmP.

Using ? = to the reference machines, so it can be overrided
by an .inc or a .conf file.

To override the default value, use, for example:

UBOOT_SIGN_ENABLE:sota:imx6ulevk = "0"

Signed-off-by: Daiane Angolini <[email protected]>
@angolini
Copy link
Contributor Author

@ricardosalveti done

Copy link
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 96c4346 into foundriesio:main Sep 21, 2023
@angolini angolini deleted the ubootsign branch August 21, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants