RFC: Add CDI generator for Wayland displays in (x)wayland images #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Container Device Interface(CDI) is a specification supported by tools like Docker and Podman to more easily access hardware. Given the hardware-specific nature of our platform, this feature is generically useful to our users and should be enabled. Signed-off-by: Andy Doan <[email protected]>
This change introduces logic to generate a CDI definition for the Weston display created at boot. With CDI enabled in a container runtime like Docker, you could run Wayland apps with a command like: running: ``` docker run --rm -it --device=org.wayland/display=wayland-1 ubuntu ``` Signed-off-by: Andy Doan <[email protected]>
|
@ricardosalveti @EmbeddedAndroid - This is a rough idea of how we could start to use CDI to make accessing hardware inside containers easier. There are a couple of ways this could be done by I've chosen an approach that is:
We could totally change this, but I wanted to get a dialog started. |
| @@ -5,3 +5,4 @@ DISTROOVERRIDES = "lmp:lmp-wayland" | |||
| DISTRO_NAME = "Linux-microPlatform Wayland" | |||
|
|
|||
| DISTRO_FEATURES:append = " wayland opengl vulkan" | |||
| IMAGE_INSTALL:append:lmp-wayland = " wayland-cdi" | |||
There was a problem hiding this comment.
I would probably move this to meta-lmp-base/recipes-samples/images/lmp-feature-docker.inc, and have it conditional to wayland (via DISTRO_FEATURES):
${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland-cdi, '', d)}
There was a problem hiding this comment.
Signed-off-by: Andy Doan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a hard-to-remember way of running wayland applications inside Docker. By leveraging CDI we can make this much easier for users so that you could simply run:
and have all the correct bind-mounts and environment variables set inside the container.