Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: accept generic header in meta builder #30

Merged
merged 2 commits into from
Nov 9, 2024
Merged

fix: accept generic header in meta builder #30

merged 2 commits into from
Nov 9, 2024

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Nov 8, 2024 •
edited
Loading

Motivation

Currently, we only accept blocks with strict type alloy_consensus::Header in the with_block method of BlockchainDbMeta. This means we cannot use the builder for blocks with AnyHeader.

Solution

Make with_block generic over alloy_consensus::BlockHeader

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya self-assigned this Nov 8, 2024
@mattsse mattsse merged commit 4ea5f75 into main Nov 9, 2024
16 checks passed
@mattsse mattsse deleted the yash/fix-block branch November 9, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees

@yash-atreya yash-atreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yash-atreya @mattsse