nix: add build via crate2nix, simplify dev shell #9260
Conversation
jrobsonchase
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
|
This looks like a nice improvement, worth adding I think. Also FYI @jrobsonchase I maintain an overlay here for convenience, but we also lack a build from source which you're adding: https://github.com/shazow/foundry.nix Once this is merged we can integrate that as an option too. |
| rust-overlay.overlays.default | ||
| solc.overlay | ||
| (final: prev: { | ||
| solc = (solc.mkDefault final final.solc_0_8_27); |
There was a problem hiding this comment.
solc 0.8.28 has been released: https://soliditylang.org/blog/2024/10/09/solidity-0.8.28-release-announcement
is there a good way to make sure this stays up to date? or does it not matter too much as you are dynamically pulling in solc regardless?
There was a problem hiding this comment.
The source we retrieve it from is https://github.com/alloy-rs/svm-rs/blob/b97a212ddd72671d3f93d3b8c773ffe2edfb1ece/crates/svm-rs/src/install.rs#L251
| solc | ||
| anvil | ||
| cast | ||
| chisel | ||
| forge |
There was a problem hiding this comment.
is there a way we could test / evaluate the working of flake.nix in the CI and make some basic assertions?
|
Hi @jrobsonchase, small bump Are you seeing any blockers for this PR to move forward? Just so I understand, would Nix require a package to be published to crates.io or would a tagged Github release suffice? |
Motivation
I wanted an easy-to-use package for NixOS. It doesn't appear to exist in upstream nixpkgs, so adding one to the existing flake is the next best approach.
Solution
Add a dependency on crate2nix and use it to analyze and build the workspace.
I also simplified the
devShell, sinceinputsFromshould theoretically pull in all of the other things needed to build the package. It's possible that I removed too much there, so I may need someone else to give it a try and see if I've broken something for them.