-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for numbers in multicall #2612
Conversation
Added new Cast feature to Unreleased section: support for numbers without quotes in multicall inputs
@kfastov can you please also test the case where the number exceeds the limit (so we make sure it fails with a reasonable message)? |
@kfastov bump |
@kfastov are you still working on this? Please let me know so i can reassign if you're not :) |
Hi @Arcticae |
Thx for the update 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @cptartur can you assign someone to take a second look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left only two nits, looking good 👍
Wrap number and string literals and data types as suggested by @franciszekjob Co-authored-by: Franciszek Job <[email protected]>
@franciszekjob Addressed the nits, please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kfastov thx for your contribution! |
Closes #2245
Introduced changes
Input
with variantsString
andNumber(i64)
to support both string and numeric inputs in TOML filesDeployCall
andInvokeCall
structs to useVec<Input>
instead ofVec<String>
for theirinputs
fieldparse_inputs
function to handle both string and numeric input variants#[serde(untagged)]
attribute to enable seamless deserialization of both input types from TOMLChecklist
CHANGELOG.md
Other notes