-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4787] More informative roll dialog titles #4884
base: 4.2.x
Are you sure you want to change the base?
Conversation
Might instead make sense to put the roll type in the main title and the actor/item name in the subtitle (if it's okay to lose "Configure Roll" - which I think it would be, since it's implicit). |
@roth-michael Give a comment on the original issue so I can assign it to you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Might also be nice to show "Concentration Save" when rolling for concentration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the small change about where we set the concentration label, but otherwise looking good.
Closes #4787
Also added a check when putting the subtitle for an activity use in a chat card whether the activity was a heal-type, if so display "Healing Roll" instead of "Damage Roll."
Attack Roll:
Damage Roll:
Skill Check:
Ability Check:
Saving Throw:
Tool Check:
Fixed subtitle for a heal activity:
Haven't tested much with super long item/actor names. Might make sense to put them as subtitles instead of titles.