fix(core): esbuild with cjs, fixes #115 #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous output of core was esm, but as the file is .js and no type module or exports are present in package.json both require and import fail.
Changing the format to cjs fixes the issue, the size of dist isn't any larger. That said if we're using esbuild with sourcemaps we could minify to get a much smaller payload?
I chose cjs instead of esm + type module because the esm output from esbuild didn't work with lodash.
Motivation and Context
Fixes #115.
How Has This Been Tested?
Yes.
Screenshots (if appropriate):
Types of changes
Checklist: