Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use libc::O_DIRECT for multi target/os/arch #554

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jun 4, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title. O_DIRECT value differs on different platforms.

// linux amd64
pub const O_DIRECT: ::c_int = 0x4000;
// linux aarch64
pub const O_DIRECT: ::c_int = 0x10000;

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#555

@MrCroxx MrCroxx added the bug Something isn't working label Jun 4, 2024
@MrCroxx MrCroxx added this to the v0.9 milestone Jun 4, 2024
@MrCroxx MrCroxx self-assigned this Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (3215bb1) to head (7f93a71).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
+ Coverage   86.32%   86.33%   +0.01%     
==========================================
  Files          58       58              
  Lines        7554     7554              
==========================================
+ Hits         6521     6522       +1     
+ Misses       1033     1032       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx merged commit 7d93290 into main Jun 4, 2024
16 checks passed
@MrCroxx MrCroxx deleted the xx/fix-odirect branch June 4, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant