Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring in ui polish with latest code + add interactions between map and table #132

Merged
merged 4 commits into from
Mar 9, 2022

Conversation

smcalilly
Copy link
Contributor

@smcalilly smcalilly commented Feb 28, 2022

Overview

This PR has a ton of UI changes for issue #125. There are a lot of CSS changes and UI element tweaks.

It also includes some React code changes for #120 and #96. The changes let a user select a row in the table which will open a popup for that row's geometry and allow the user to save that geometry. Similarly, a user can select a single geometry and save the geometry.

Demo

Screen Shot 2022-02-16 at 3 56 30 PM
Screen Shot 2022-02-16 at 3 56 41 PM
Screen Shot 2022-02-16 at 3 57 06 PM
Screen Shot 2022-02-16 at 3 57 36 PM
Screen Shot 2022-02-16 at 3 57 53 PM

Notes

At a high level, made these UI changes:

  • widened the container that holds all the form elements
  • branding: changed green for the header, added their logo, and used their icons
  • changed all the links and buttons from dark green to light green
  • most significant styling changes:
    • phase add / edit form
    • GIS tool

Testing Instructions

to test the map changes:

  • click on a row in the table and confirm that the popup opens and you can save the selected asset
  • click on an asset in the map and confirm that the popup opens and you can save the selected asset

@smcalilly smcalilly temporarily deployed to ccfp-asset-d-ui-polish-5fk6dqu February 28, 2022 16:51 Inactive
@smcalilly smcalilly mentioned this pull request Feb 28, 2022
@smcalilly smcalilly marked this pull request as ready for review February 28, 2022 19:58
@smcalilly smcalilly requested a review from fgregg February 28, 2022 19:59
@smcalilly smcalilly changed the title bring in ui polish with latest code bring in ui polish with latest code + add interactions between map and table Mar 1, 2022
@fgregg
Copy link
Collaborator

fgregg commented Mar 7, 2022

@smcalilly could you redeploy?

@smcalilly smcalilly temporarily deployed to ccfp-asset-d-ui-polish-tmvktzk March 7, 2022 16:29 Inactive
@smcalilly
Copy link
Contributor Author

@fgregg
Copy link
Collaborator

fgregg commented Mar 7, 2022

looking slick. lets change visually change selected assets that have not been "saved" and let's also change the "save asset" button to "add asset to phase" button

@smcalilly smcalilly temporarily deployed to ccfp-asset-d-ui-polish-tmvktzk March 8, 2022 18:40 Inactive
@smcalilly
Copy link
Contributor Author

@fgregg made the requested changes. in the process, i found an edge case that i fixed and attempted to articulate in this code comment. i also changed the name of some variables to be more clear, because i found that parts of the code was hard to understand......despite being the writer of it......

here's a demo of how it looks/works:
select-asset

@smcalilly smcalilly temporarily deployed to ccfp-asset-d-ui-polish-tmvktzk March 8, 2022 21:52 Inactive
@smcalilly smcalilly merged commit 9d63fcd into master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants