fix: remove timeout from default args (#56)

fredrikaverpil · Jun 25, 2024 · b3821da · b3821da
1 parent 72b4ffb
commit b3821da
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -94,13 +94,13 @@ return {
 
 ## ⚙️ Configuration
 
-| Argument                 | Default value                                   | Description                                                                               |
-| ------------------------ | ----------------------------------------------- | ----------------------------------------------------------------------------------------- |
-| `go_test_args`           | `{ "-v", "-race", "-count=1", "-timeout=60s" }` | Arguments to pass into `go test`.                                                         |
-| `dap_go_enabled`         | `false`                                         | Leverage [leoluz/nvim-dap-go](https://github.com/leoluz/nvim-dap-go) for debugging tests. |
-| `dap_go_opts`            | `{}`                                            | Options to pass into `require("dap-go").setup()`.                                         |
-| `warn_test_name_dupes`   | `true`                                          | Warn about duplicate test names within the same Go package.                               |
-| `warn_test_not_executed` | `true`                                          | Warn if test was not executed.                                                            |
+| Argument                 | Default value                   | Description                                                                               |
+| ------------------------ | ------------------------------- | ----------------------------------------------------------------------------------------- |
+| `go_test_args`           | `{ "-v", "-race", "-count=1" }` | Arguments to pass into `go test`.                                                         |
+| `dap_go_enabled`         | `false`                         | Leverage [leoluz/nvim-dap-go](https://github.com/leoluz/nvim-dap-go) for debugging tests. |
+| `dap_go_opts`            | `{}`                            | Options to pass into `require("dap-go").setup()`.                                         |
+| `warn_test_name_dupes`   | `true`                          | Warn about duplicate test names within the same Go package.                               |
+| `warn_test_not_executed` | `true`                          | Warn if test was not executed.                                                            |
 
 ### Example configuration: custom `go test` arguments
 
@@ -111,6 +111,8 @@ local config = { -- Specify configuration
     "-race",
     "-count=1",
     "-timeout=60s",
+    "-parallel=1",
+    "-p=2",
     "-coverprofile=" .. vim.fn.getcwd() .. "/coverage.out",
   },
 }
@@ -125,6 +127,8 @@ Note that the example above writes a coverage file. You can use
 [andythigpen/nvim-coverage](https://github.com/andythigpen/nvim-coverage) to
 show the coverage in Neovim.
 
+See `go help test` for possible arguments.
+
 ### Example configuration: debugging
 
 To debug tests, make sure you depend on

diff --git a/lua/neotest-golang/options.lua b/lua/neotest-golang/options.lua
@@ -11,7 +11,6 @@ function Opts:new(opts)
       "-v",
       "-race",
       "-count=1",
-      "-timeout=60s",
     }
   self.dap_go_enabled = opts.dap_go_enabled or false
   self.dap_go_opts = opts.dap_go_opts or {}

diff --git a/tests/unit/options_spec.lua b/tests/unit/options_spec.lua
@@ -9,7 +9,6 @@ describe("Options are set up", function()
         "-v",
         "-race",
         "-count=1",
-        "-timeout=60s",
       },
       warn_test_name_dupes = true,
       warn_test_not_executed = true,
@@ -28,7 +27,6 @@ describe("Options are set up", function()
         "-race",
         "-count=1",
         "-parallel=1", -- non-default
-        "-timeout=60s",
       },
       warn_test_name_dupes = true,
       warn_test_not_executed = true,