Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plug initialisation step compliant with the spec #36

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

odiroot
Copy link
Contributor

@odiroot odiroot commented Jan 9, 2024

According to the official header plugin.h

// If init returns false, the host must destroy the plugin instance.
   // If init returns true, then the plugin is initialized and in the deactivated state.

Trying to activate the plugin when it cannot be initialised can result in an instant crash.

According to the official header [plugin.h](https://github.com/free-audio/clap/blob/main/include/clap/plugin.h)

```
// If init returns false, the host must destroy the plugin instance.
   // If init returns true, then the plugin is initialized and in the deactivated state.
```
@baconpaul
Copy link
Collaborator

Oh thank you!

@baconpaul baconpaul merged commit 79fc46c into free-audio:main Jan 10, 2024
3 checks passed
@odiroot
Copy link
Contributor Author

odiroot commented Jan 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants