A first attempt at improving the adjust size approach #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first shot at making adjust size / set size work. It naively just applies aspect ratio to with which makes corner and bottom drags work but not side drags. An algorithm to work for all drags without knowing the direction of the user gesture which is stable continues to elude me, but I wanted at least something more reasonable in teh codebase before I go on vacation. Addresses free-audio#56
baconpaul
force-pushed
the
first-size-fix
branch
from
6a7f102
to
17640d7
Compare
|
So @jatinchowdhury18 two questions
|
|
To rerun a workflow you need to make a second commit on your branch and push normally. GitHub will trigger a new pipeline. |
ahh thanks |
|
It's also possible to manually trigger the CI workflow from here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first shot at making adjust size / set size work.
It naively just applies aspect ratio to with which makes corner
and bottom drags work but not side drags.
An algorithm to work for all drags without knowing the direction
of the user gesture which is stable continues to elude me, but I wanted
at least something more reasonable in teh codebase before I go on vacation.
Addresses #56