Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add multipart tags #48

Merged
merged 32 commits into from
Oct 30, 2024

Conversation

pf-lin
Copy link

@pf-lin pf-lin commented Oct 28, 2024

Description

Add multipart tags

[SMF]

  • UpdateSmContextResponse200
  • UpdateSmContextResponse400
  • UpdatePduSessionResponse200
  • UpdatePduSessionResponse400
  • ModifyPduSessionResponse200
  • ModifyPduSessionResponse400
  • ReleasePduSessionResponse200
  • PostPduSessionsResponse400
  • UpdateSmContextRequest
  • DeliverRequest
  • ModifyPduSessionRequest
  • PostPduSessionsRequest
  • ReleasePduSessionRequest
  • ReleaseSmContextRequest
  • SendMoDataRequest
  • TransferMoDataRequest
  • TransferMtDataRequest
  • TransferMtDataismfRequest
  • UpdatePduSessionRequest

[AMF]

  • CancelRelocateUeContextRequest
  • ContextCreateRequest
  • ContextUpdateRequest
  • CreateUeContextRequest
  • N1MessageNotifyRequest
  • NonUeN2InfoNotifyRequest
  • N2InfoNotifyRequest
  • N2MessageTransferRequest
  • NonUeN2MessageTransferRequest
  • NullRequest
  • RelocateUeContextRequest
  • UeContextTransferRequest

Modify the content type of the multipart tags

  • in BinaryDataN2SmInformation within UpdateSmContextResponse200

Spec

Source file: 3GPP TS 29.502 V17.12.0

Screenshot

image
image
image

@andy89923 andy89923 self-requested a review October 28, 2024 06:58
@andy89923 andy89923 marked this pull request as draft October 28, 2024 07:22
@pf-lin pf-lin changed the title fix: add multipart tags in UpdateSmContextResponse200 fix: add multipart tags Oct 28, 2024
@pf-lin pf-lin marked this pull request as ready for review October 28, 2024 09:31
andy89923
andy89923 previously approved these changes Oct 29, 2024
@andy89923 andy89923 dismissed their stale review October 30, 2024 02:48

UpdateSmContextRequest should have multipart

@ianchen0119
Copy link
Contributor

@pf-lin @andy89923
Is this PR ready to be reviewed?
Tks

@pf-lin
Copy link
Author

pf-lin commented Oct 30, 2024

@ianchen0119 Yes!

@ianchen0119 ianchen0119 merged commit 51c7fcd into free5gc:feat/r17 Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants