Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove innerHTML sink in Palindrome Checker #627

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

sylwia-budzynska
Copy link
Contributor

Checklist:

Closes #XXXXX

Please also see an email I sent to possible-security-issue at freecodecamp dot org.

Interpolating user input into innerHTML sink can lead to security issues.

This pull request changes the innerHTML sink to innerText in the Palindrome Checker project, which fixes the vulnerability.

This is my first contribution to freeCodeCamp, let me know if anything could be improved! I also wanted to extend my thanks to the freeCodeCamp team for creating such a great learning platform 🙌

@sylwia-budzynska sylwia-budzynska requested a review from a team as a code owner November 13, 2024 18:10
@raisedadead raisedadead merged commit 47ac582 into freeCodeCamp:main Nov 20, 2024
2 checks passed
@raisedadead
Copy link
Member

✨ ✨ AWESOME! ✨ ✨

LGTM.

Thanks for this pull request and for contributing to the codebase for the first time. We will be looking forward to more contributions in the future.

Happy contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants