Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get linting working #82

Merged
merged 23 commits into from
Aug 17, 2023
Merged

feat: get linting working #82

merged 23 commits into from
Aug 17, 2023

Conversation

Sembauke
Copy link
Member

Checklist:

Closes #XXXXX

@socket-security
Copy link

socket-security bot commented Aug 11, 2023 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
husky 8.0.3 environment +0 6.44 kB typicode
eslint-plugin-unused-imports 3.0.0 None +1 28.6 kB sweepline
autoprefixer 10.4.14 environment +6 2.64 MB ai
lint-staged 14.0.0 environment +32 988 kB okonet

🚮 Removed packages: [email protected]

Nirajn2311
Nirajn2311 reviewed Aug 11, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@Sembauke Sembauke marked this pull request as ready for review August 11, 2023 11:03
@Sembauke Sembauke requested a review from a team as a code owner August 11, 2023 11:03
ojeytonwilliams
ojeytonwilliams previously requested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any linting really should run in CI. If not, we won't realise there are issues.

publish-frontend/.eslintrc.json Outdated Show resolved Hide resolved
publish-frontend/.lintstagedrc Outdated Show resolved Hide resolved
@Sembauke Sembauke marked this pull request as draft August 11, 2023 12:24
@Sembauke Sembauke marked this pull request as ready for review August 16, 2023 06:44
ojeytonwilliams
ojeytonwilliams requested changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @Sembauke, just a couple of minor things:

publish-frontend/src/lib/users.js Outdated Show resolved Hide resolved
publish-frontend/src/pages/articles/preview/[articleId].js Outdated Show resolved Hide resolved
@Sembauke @ojeytonwilliams
Apply suggestions from code review
94d94c7 
Co-authored-by: Oliver Eyton-Williams <[email protected]>
Nirajn2311
Nirajn2311 previously requested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@Nirajn2311 Nirajn2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we've got ESLint and Prettier in this PR, might as well get EditorConfig in here also. The same config used in main repo can be used here.

Nirajn2311
Nirajn2311 reviewed Aug 17, 2023
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
publish-frontend/package.json Outdated Show resolved Hide resolved
@Nirajn2311 Nirajn2311 merged commit f8d9fc3 into main Aug 17, 2023
2 checks passed
@Nirajn2311 Nirajn2311 deleted the feat/linting branch August 17, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naomi-lgbt naomi-lgbt naomi-lgbt left review comments

@Nirajn2311 Nirajn2311 Nirajn2311 approved these changes

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sembauke @ojeytonwilliams @Nirajn2311 @naomi-lgbt