Add hardening measures on untar #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds hardening measures while untaring archives fetched over the network (including FreeBSD tarballs and iocage plugins), as implemented by TrueNAS, see: truenas/iocage#358 This reduces the impact of intentionally malicious or accidentally broken archives. Please note that users are still advised to only fetch from trusted sources and make use of TLS to prevent MITM attacks.
Pull Request Test Coverage Report for Build 11989389854Details
💛 - Coveralls |
|
Thank you ! |
dgeo
pushed a commit
to criecm/iocage
that referenced
this pull request
Nov 29, 2024
This adds hardening measures while untaring archives fetched over the network (including FreeBSD tarballs and iocage plugins), as implemented by TrueNAS, see: truenas/iocage#358 This reduces the impact of intentionally malicious or accidentally broken archives. Please note that users are still advised to only fetch from trusted sources and make use of TLS to prevent MITM attacks.
grembo
added a commit
to grembo/iocage
that referenced
this pull request
Dec 8, 2024
In freebsd#49 a hardening measure was imported from truenas/iocage#358. This hardening measure limits what can be extracted (location and attributes). It is implemented by applying the 'tar' filter from tarfile. That filter does this[0]: - Strip leading slashes (/ and os.sep) from filenames. - Refuse to extract files with absolute paths (in case the name is absolute even after stripping slashes, e.g. C:/foo on Windows). This raises AbsolutePathError. - Refuse to extract files whose absolute path (after following symlinks) would end up outside the destination. This raises OutsideDestinationError. - Clear high mode bits (setuid, setgid, sticky) and group/other write bits (S_IWGRP | S_IWOTH). While the first three modifications are desirable, the last one damages the extracted release image, as things like sticky bits and world writable files are required by a proper FreeBSD (jail) installation. Fixes freebsd#54 [0]https://docs.python.org/3/library/tarfile.html#tarfile-extraction-filter
2 tasks
dgeo
pushed a commit
that referenced
this pull request
Dec 9, 2024
In #49 a hardening measure was imported from truenas/iocage#358. This hardening measure limits what can be extracted (location and attributes). It is implemented by applying the 'tar' filter from tarfile. That filter does this[0]: - Strip leading slashes (/ and os.sep) from filenames. - Refuse to extract files with absolute paths (in case the name is absolute even after stripping slashes, e.g. C:/foo on Windows). This raises AbsolutePathError. - Refuse to extract files whose absolute path (after following symlinks) would end up outside the destination. This raises OutsideDestinationError. - Clear high mode bits (setuid, setgid, sticky) and group/other write bits (S_IWGRP | S_IWOTH). While the first three modifications are desirable, the last one damages the extracted release image, as things like sticky bits and world writable files are required by a proper FreeBSD (jail) installation. Fixes #54 [0]https://docs.python.org/3/library/tarfile.html#tarfile-extraction-filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds hardening measures while untaring archives fetched over the network (including FreeBSD tarballs and iocage plugins), as implemented by TrueNAS, see:
truenas/iocage#358
This reduces the impact of intentionally malicious or accidentally broken archives.
Please note that users are still advised to only fetch from trusted sources and make use of TLS to prevent MITM attacks.
Make sure to follow and check these boxes before submitting a PR! Thank you.