Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sort releases #51

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix sort releases #51

merged 1 commit into from
Nov 29, 2024

Conversation

dgeo
Copy link
Contributor

@dgeo dgeo commented Nov 29, 2024

reorder code in sort_releases() to correctly detect list -r case

fix #50

@dgeo
fix sort releases
b41bc81 
reorder code in `sort_releases()` to correctly detect `list -r` case

fix freebsd#50
@dgeo dgeo added this to the 1.9 milestone Nov 29, 2024
@dgeo dgeo added the bug Something isn't working label Nov 29, 2024
@dgeo dgeo self-assigned this Nov 29, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12085458929

Details

  • 0 of 14 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 7.748%
Changes Missing Coverage Covered Lines Changed/Added Lines %
iocage_lib/ioc_common.py 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
iocage_lib/ioc_common.py 1 17.03%
Totals Coverage Status
Change from base Build 12085176560: 0.002%
Covered Lines: 799
Relevant Lines: 7802
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Nov 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12085458929

Details

  • 0 of 14 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 7.748%
Changes Missing Coverage Covered Lines Changed/Added Lines %
iocage_lib/ioc_common.py 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
iocage_lib/ioc_common.py 1 17.03%
Totals Coverage Status
Change from base Build 12085176560: 0.002%
Covered Lines: 799
Relevant Lines: 7802
💛 - Coveralls

@dgeo dgeo merged commit 32ba869 into freebsd:master Nov 29, 2024
2 checks passed
@dgeo dgeo deleted the sort_releases branch November 29, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dgeo dgeo

Labels
bug Something isn't working
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

iocage list -r fails with 9 releases
2 participants
@dgeo @coveralls