Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not place empty HTTP_PROXY in env #8

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

dgeo
Copy link
Contributor

@dgeo dgeo commented May 31, 2024

Just test for non-emptiness before making it available to exec and upgrade processes

fix #7

Just test for non-emptiness before making it available to exec and upgrade processes

fix freebsd#7
@dgeo dgeo merged commit 574f997 into freebsd:master May 31, 2024
1 check passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9319894713

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 9 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 8.197%

Changes Missing Coverage Covered Lines Changed/Added Lines %
iocage_lib/ioc_exec.py 3 6 50.0%
iocage_lib/ioc_upgrade.py 0 3 0.0%
Totals Coverage Status
Change from base Build 9317671310: 0.02%
Covered Lines: 799
Relevant Lines: 7754

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iocage upgrade fails to download metadata files
2 participants