Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore: ignore new generated test files #2357

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Conversation

ifreund
Copy link
Contributor

@ifreund ifreund commented Nov 24, 2024

It seems that it was forgotten to add these filse to the .gitignore when the new tests were added.

Sponsored by: The FreeBSD Foundation

It seems that it was forgotten to add these filse to the .gitignore when
the new tests were added.

Sponsored by:	The FreeBSD Foundation
This behavior was changed in c2fe22b.

Sponsored by:	The FreeBSD Foundation
@ifreund
Copy link
Contributor Author

ifreund commented Nov 24, 2024

not sure what's up with the CI failures... Oh I guess master branch is failing as well :/

@ifreund ifreund force-pushed the tests-gitignore branch 3 times, most recently from 60dbf29 to 26845a4 Compare November 24, 2024 16:05
@ifreund
Copy link
Contributor Author

ifreund commented Nov 24, 2024

My attempt to fix the failure on Debian has thus far only been partially successful, not sure what I'm missing there right now, will have another look tomorrow.

The failure on FreeBSD seems to be a regression from #2355. install ends up getting called without enough arguments in the Makefile.

@bapt bapt merged commit 5fc9047 into freebsd:main Nov 24, 2024
10 of 12 checks passed
@ifreund ifreund deleted the tests-gitignore branch November 25, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants