Chisel3 vs compat #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
reviewed
Dec 6, 2019
There was a problem hiding this comment.
This looks great! Thanks for taking the time to add these.
Would you be willing to convert these to use mdoc for the added type safety? I'm trying to at least get new code into this format...
There's some examples in annotations.md. The downside is that it actually runs so there's no support for bare statements outside of modules.
|
I'll take care of the mdoc conversion, don't worry about it @kOstby |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some examples on the behaviour around compat/chisel3 Reg() + chiselTypeOf(), and WireInit + DontCare that had me puzzled for a bit.