Changed variable name #6696
Open
Changed variable name #6696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoktm
requested changes
Dec 1, 2022
There was a problem hiding this comment.
Hi @wallbloggerbeing, thanks for the PR! In the future please use the pull request template we've set up, it makes it easier for us to review it.
The code change looks good, but could you modify the commit message to clarify what function name is being changed and why?
For example:
Address PytestReturnNotNoneWarning by renaming function
Because the function is named `test_should_run`, pytest treats it as a test rather than a
function. Renaming it fixes that.
Fixes #6694.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address PytestReturnNotNoneWarning by renaming function
Because the function is named
test_should_run, pytest treats it as a test rather than afunction. Renaming it fixes that.
Fixes #6694.