fix for npt #1057
Open
fix for npt #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for ntp server. This way when you set the ntp_server or the pool it doesn't still take no_ntp
TASK [freeipa.ansible_freeipa.ipaclient : Install - IPA client test] ***********
fatal: [ipamaster.int.REDACTED.com]: FAILED! => {"changed": false, "msg": "--ntp-pool cannot be used together with --no-ntp"}
|
@t-woerner, @rjeffman could you guys have a look at this? Thanks in advance. |
|
Although you change fixes the issue, I'm not a fan of @lessfoobar, I'm somewhat drowning in other issues right now, and giving your PR a proper review is on my TODO list. I hope to be able to look at it in the next week or the other. |
|
okay, ping me up again when you have the time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for ntp server. This way when you set the ntp_server or the pool it doesn't still take no_ntp