WIP: Define module parameters only once. #1314
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeffman
force-pushed
the
entryfactory_steroids
branch
2 times, most recently
from
670b208
to
873a77e
Compare
…jects
When setting multiple objects in the same tasks, some validation and
proper capitalization of parameter values were skipped.
By using the EntryFactory to extract the entries data both issues are
fixed.
New test added to ipagroup suite:
tests/group/test_groups_member_case_insensitive.yml
Note: This is a temporary commit that should be part of another PR. It's
been added here to show the feasiability of the EntryFactory class.
Tests for case insensitive comparison must be added before this change
is merged.
rjeffman
force-pushed
the
entryfactory_steroids
branch
from
873a77e
to
c301ec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created over PR #1290 and modifies EntryFactory so that is
instantiates the IPAAnsibleModule and allows the definition of the
module objects only once, while allowing the simple usage case of a
single entry defined in a task, or the case where multiple entries are
used.
Modules ipasudorule and ipagroup are modified to use the new mechanism.