[Active users][Settings][Kebab] Add 'OTP token' option #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carma12
force-pushed
the
kebab-add-otp-token-option
branch
3 times, most recently
from
c17c473
to
17533ea
Compare
pvoborni
requested changes
Jan 5, 2024
|
Most of the suggestions from the review are in pvoborni@78663f8 - you can apply the commit. It was written partly to verify what I wrote is correct, second reason is that code is better illustration. |
carma12
force-pushed
the
kebab-add-otp-token-option
branch
3 times, most recently
from
75cbf93
to
0d21973
Compare
carma12
force-pushed
the
kebab-add-otp-token-option
branch
from
0d21973
to
74fd557
Compare
|
@pvoborni - I have already adapted the code based on your comments. |
carma12
force-pushed
the
kebab-add-otp-token-option
branch
5 times, most recently
from
5914a0d
to
a7a9f41
Compare
After adding a new OTP Token, a QR code to configure the token must be generated. Thus, a React-compatible library to generate those QR codes need to be used in the project. The qrcode.react[1] library has been chosen by its effective way of create and customize QR codes. [1] - https://github.com/zpao/qrcode.react Signed-off-by: Carla Martinez <[email protected]>
carma12
force-pushed
the
kebab-add-otp-token-option
branch
from
a7a9f41
to
61edf95
Compare
pvoborni
requested changes
Jan 12, 2024
carma12
force-pushed
the
kebab-add-otp-token-option
branch
from
61edf95
to
037943a
Compare
The 'Add OTP token' option creates a new OTP token associated to a specific user. The QR code has been generated using the qrcode.react[1] library. [1]- https://github.com/zpao/qrcode.react Signed-off-by: Carla Martinez <[email protected]>
carma12
force-pushed
the
kebab-add-otp-token-option
branch
from
037943a
to
1445491
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Add OTP token' option creates a new OTP token associated with a specific user.
After adding a new OTP Token, a QR code to configure the token must be generated. Thus, a React-compatible library to generate those QR codes needs to be used in the project.
The qrcode.react[1] library has been chosen because of its effective way of creating and customizing QR codes. To install the package just run:
npm install.[1] - https://github.com/zpao/qrcode.react