[Is a member of][User groups] 'Delete' button functionality #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `User` data type needs the following parameters that will be managed in the 'Is a member of' section: - `memberof_group` - `memberof_netgroup` - `memberof_role` - `memberof_hbacrule` - `memberof_sudorule` - `memberof_subid` Signed-off-by: Carla Martinez <[email protected]>
As other components are using the `MemberOfTable` and `MemberOfToolbar` components, there are many dependencies to correct and adapt. The new `MemberOfTableNew` and `MemberOfToolbarNew` have been defined to be used when adapting the 'User groups' data only. The same has been done in the data types by creating a new `UserGroupNew` type that will be used later. The `normalizeString` utility function is meant to normalize LDAP values from `string[]` to `string`. Signed-off-by: Carla Martinez <[email protected]>
The dummy data must be replaced by the data from the API for the 'User groups' only. Signed-off-by: Carla Martinez <[email protected]>
The 'Add' button functionality allows to associate any user group's member to a given user. Signed-off-by: Carla Martinez <[email protected]>
The 'Delete' button should delete a list of members from the User groups list for a given user. The `MemberOfDeleteModalNew` and `MemberOfDeletedGroupsTableNew` have been adapted from the original ones (without the `new` suffix) to adapt the new data and keep the functionality in other pages (that is not adapted to the C.L. yet). These new components will eventually replace the older ones. Signed-off-by: Carla Martinez <[email protected]>
| form="modal-form" | ||
| onClick={onClickAddGroupHandler} | ||
| > | ||
| Add |
There was a problem hiding this comment.
Could you add the spinning props here and disable the Add button at the same time?
| onClick={deleteGroups} | ||
| form="active-users-remove-groups-modal" | ||
| > | ||
| Delete |
There was a problem hiding this comment.
Spin/disable the button here as well
|
@carma12 - I think you need to rebase this PR as it does not apply to main branch |
|
Closing this PR in favor of this one: #301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Delete' button should delete a list of members from the User groups list for a given user.
The
MemberOfDeleteModalNewandMemberOfDeletedGroupsTableNewhave been adapted from the original ones (without thenewsuffix) to adapt the new data and keep the functionality in other pages (that is not adapted to the C.L. yet). These new components will eventually replace the older ones.This PR depends on this one to be merged: #272