[Is a member of] User groups sync data #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carma12
changed the title
carma12
force-pushed
the
user-groups-sync-data
branch
2 times, most recently
from
0602a5c
to
a7e209f
Compare
carma12
changed the title
The functionality of `MemberOfAddModal` is going to change but there are some components that depends on the current functionality. That's why it needs to be renamed. Signed-off-by: Carla Martinez <[email protected]>
Same as the `MemberOfAddModal`. Signed-off-by: Carla Martinez <[email protected]>
The new 'Add' modal should be adapted to the User groups data. Signed-off-by: Carla Martinez <[email protected]>
The 'Delete' modal functionality must be adapted to work with the User groups data. Signed-off-by: Carla Martinez <[email protected]>
Previous preparation of some elements is needed: - The `User` data type needs the following parameters that will be managed in the 'Is a member of' section: - `memberof_group` - `memberof_netgroup` - `memberof_role` - `memberof_hbacrule` - `memberof_sudorule` - `memberof_subid` - The `useGettingGroupsQuery` endpoint wrapper to make the API call - The original `UserGroup` data type has been replaced by the `UserGroupOld` one. All the files that use that type have been adapted - The new `UserGroup` type will contain the new data structure. - The `useUserMemberOfData` hook to retrieve and parse the data - The `normalizeString` helper function to normalize string LDAP values Signed-off-by: Carla Martinez <[email protected]>
The dummy data must be replaced by the data from the API for the 'User groups' only. Signed-off-by: Carla Martinez <[email protected]>
The Redux functionality won't be used in this context, so it can be safely removed. Signed-off-by: Carla Martinez <[email protected]>
carma12
force-pushed
the
user-groups-sync-data
branch
from
1cf4659
to
ec0e39e
Compare
|
Closing this PR in favor of this one: #293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'User groups' dummy data has been synchronized using the real data from the API.
This PR depends on this one to be merged: #288