Issue 330 - Add tests for Hosts page #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreynolds389
force-pushed
the
test_hosts
branch
from
3666f8f
to
2b0bff9
Compare
carma12
requested changes
Apr 12, 2024
tests/features/host_handling.feature
Outdated
| Given I am logged in as "Administrator" | ||
| Given I am on "hosts" page | ||
|
|
||
| Scenario Outline: Add a new host |
There was a problem hiding this comment.
It would be nice to add more tests to check the different addition of new hosts (as they're sifferent ways/options to do so). I.e.:
- Partial + no checkbox selected (done ✅ )
- Complete (with full data) + no checkbox selected
- Complete (with full data) + 'Force' checkbox
- Partial + 'Generate OTP' / 'Suppress processing of membership attributes' checkbox
mreynolds389
force-pushed
the
test_hosts
branch
3 times, most recently
from
7032a03
to
138c120
Compare
|
Also I am very open to renaming things in this PR. I use "partial" entry a lot. Couldn't come up with anything better. I also use "modal" for describing some functions in common.ts, but that might not be entirely correct. Maybe it applies outside of modals? |
miskopo
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Hello @mreynolds389 , thank you for your contribution, please see the in-line comments.
|
Also, when labels' "I type in the field {string} text {string}", ...from |
miskopo
approved these changes
Apr 19, 2024
miskopo
added
ack
Add tests for adding/deleting hosts, and automember rebuild Since we don't know the host name I created "partial" functions for elements that "start with" a value, instead of searching for the entire value. Fixes: freeipa#330 Signed-off-by: Mark Reynolds <[email protected]>
mreynolds389
force-pushed
the
test_hosts
branch
from
279d478
to
50dbe32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for adding/deleting hosts, and automember rebuild
Since we don't know the host name I created "partial" functions for elements that "start with" a value, instead of searching for the entire value.
Fixes: #330