implement basic state aggregation #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konnov
changed the title
thpani
approved these changes
Dec 19, 2024
solarkraft/src/aggregate.ts
Outdated
| */ | ||
| /** | ||
| * A command to aggregate the full contract state from the collected transactions. | ||
| * This command is potentially expensive. In the long run, it makes sense to |
There was a problem hiding this comment.
Maybe we could say why it is expensive?
There was a problem hiding this comment.
yep, added an explanation
Co-authored-by: Thomas Pani <[email protected]>
Co-authored-by: Thomas Pani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #153. This PR implements basic state aggregation. It's probably the most straightforward approach. We need this for input generation. I believe that a high-performance approach would require much more work, which we do not have in this phase.