Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the boring typescript configs #17

Merged
merged 11 commits into from
Apr 15, 2024
Merged

Add the boring typescript configs #17

merged 11 commits into from
Apr 15, 2024

Conversation

konnov
Copy link
Contributor

@konnov konnov commented Apr 15, 2024

Closes #15. This PR adds plenty of boring config files, basically a "hello, world" of typescript + github. Even though this PR has 5.2 KLOC, there is not much happening, if you look at the change set. A massive change is caused by the license file autogenerated by source-licenser.

@konnov konnov marked this pull request as ready for review April 15, 2024 15:18
Copy link
Collaborator

@Kukovec Kukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to track package-lock.json via git? I thought this was autogen.

Comment on lines +17 to +18
# macos is burning my free minutes way too fast
#operating-system: [ubuntu-latest, macos-latest]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# macos is burning my free minutes way too fast
#operating-system: [ubuntu-latest, macos-latest]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the change here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the highlighted lines

@konnov
Copy link
Contributor Author

konnov commented Apr 15, 2024

Do we need to track package-lock.json via git? I thought this was autogen.

It is autogen but it's a good practice to add it, in order to make builds between your machine and my machine reproducible

@Kukovec
Copy link
Collaborator

Kukovec commented Apr 15, 2024

Do we need to track package-lock.json via git? I thought this was autogen.

It is autogen but it's a good practice to add, in order to make builds between your machine and my machine reproducible

I distinctly remember an issue with quint where this file would be modified by something and would always have to be stashed between git-commits

@konnov
Copy link
Contributor Author

konnov commented Apr 15, 2024

Do we need to track package-lock.json via git? I thought this was autogen.

It is autogen but it's a good practice to add, in order to make builds between your machine and my machine reproducible

I distinctly remember an issue with quint where this file would be modified by something and would always have to be stashed between git-commits

There are plenty of good answers on stack overflow btw: https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5

@Kukovec Kukovec added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 0359a22 Apr 15, 2024
2 checks passed
@Kukovec Kukovec deleted the igor/scaffolding15 branch April 15, 2024 15:32
@konnov konnov added this to the M1: Transaction extractor milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic CLI scaffolding
2 participants