-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the boring typescript configs #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to track package-lock.json
via git? I thought this was autogen.
# macos is burning my free minutes way too fast | ||
#operating-system: [ubuntu-latest, macos-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# macos is burning my free minutes way too fast | |
#operating-system: [ubuntu-latest, macos-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing the highlighted lines
It is autogen but it's a good practice to add it, in order to make builds between your machine and my machine reproducible |
I distinctly remember an issue with quint where this file would be modified by something and would always have to be stashed between git-commits |
There are plenty of good answers on stack overflow btw: https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5 |
Closes #15. This PR adds plenty of boring config files, basically a "hello, world" of typescript + github. Even though this PR has 5.2 KLOC, there is not much happening, if you look at the change set. A massive change is caused by the license file autogenerated by
source-licenser
.