Values for collections
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konnov
reviewed
Apr 18, 2024
solarkraft/src/state/value.ts
Outdated
| // Additionally, fixed-length byte arrays are valid only if their declared length matches their actual length | ||
| case "arr": { | ||
| const cast = (v as ArrValue) | ||
| const lenMismatch = ((typeof (cast.len)) !== 'undefined') && (cast.val.length !== cast.len) |
There was a problem hiding this comment.
I missed that: Why do we need explicit array length, if we can compute it from the value length?
There was a problem hiding this comment.
If you look at the bytesN constructor, that's exactly what it does. For now, I just want to keep parity with the Soroban types, where Bytes and BytesN are distinct, and if it turns out we don't need it we can axe it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #23
Introduces types and constructors for all remaining
Values (byte arrays, vectors and maps).Note the following additional refactoring:
[0, 2^n], should have been[0, 2^n))u32Thas its own type declaration (to work with byte array type restrictions)