add a simple implementation of ADR002 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kukovec
reviewed
May 16, 2024
Comment on lines
+97
to
+107
| const loaded = JSONbig.parse(contents) | ||
| return { | ||
| height: loaded.height as number, | ||
| contractId: loaded.contractId as string, | ||
| txHash: loaded.txHash as string, | ||
| method: loaded.method as string, | ||
| methodArgs: loaded.methodArgs as any[], | ||
| returnValue: loaded.returnValue, | ||
| fields: OrderedMap<string, any>(loaded.fields), | ||
| oldFields: OrderedMap<string, any>(loaded.oldFields), | ||
| } |
There was a problem hiding this comment.
I think I'd prefer to have a validation method, which checks that loaded has the correct shape, and then returns the value cast to the correct type with given field types, instead of just blind-casting each field.
There was a problem hiding this comment.
Please feel free to implement one!
Kukovec
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements ADR002.