add a simple implementation of solarkraft list
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kukovec
approved these changes
May 17, 2024
| path: string | ||
| ): Generator<ListEntry> { | ||
| for (const dirent of readdirSync(path, { withFileTypes: true })) { | ||
| if (dirent.isDirectory() && /^[0-9]+$/.exec(dirent.name)) { |
There was a problem hiding this comment.
Please add a comment explaining this regex
| withFileTypes: true, | ||
| })) { | ||
| // match all storage entries | ||
| const matcher = /^entry-([0-9a-fA-F]+)\.json$/.exec( |
There was a problem hiding this comment.
Why are we using mixed-case HEX here?
There was a problem hiding this comment.
I would be ok with lowercase, but neither Windows, nor MacOS agree with me on the capitalization of filenames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
solarkraft list. Since our file storage is very simple, the implementation is also simple.