Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ilr: fix config generation #1079

Merged
merged 1 commit into from
Nov 20, 2024
Merged

ilr: fix config generation #1079

merged 1 commit into from
Nov 20, 2024

Conversation

pktpls
Copy link
Contributor

@pktpls pktpls commented Nov 19, 2024

mesh_ap must be a host with wireless_devices

(I run a full config generation for all hosts every now and then)

mesh_ap must be a host with wireless_devices
Copy link
Contributor

@FFHener FFHener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove both interfaces completly insteod of just the 2 lines as they are clearly not needed here. Thanks for catching

@pktpls
Copy link
Contributor Author

pktpls commented Nov 19, 2024

Mir ist es eigentlich lieber wenn die ILR Leute das selber regeln, wer weiß wie dort der Stand ist und was ich mglw. kaputt mache wenn ich neue Config flashe. Finde es auch nicht soo schlimm wenn bei einzelnen Standorten Zwischenstände in Git stehen.

Wollte hier nur den Build fixen, das ist doch schon ein Gewinn.

@Noki
Copy link
Member

Noki commented Nov 20, 2024

The core router model has no wireless interfaces and therefore this part of the config is obviously wrong. I think the best way to go is to fully delete the interfaces as suggested by @FFHener and then request a review from @Akira25, as not deleting the interfaces just transforms the configuration into another questionable state and we also use the configurations to update information in the wiki.

@FFHener
Copy link
Contributor

FFHener commented Nov 20, 2024

Ich kann damit leben das zu mergen und ein Issue aufzumachen, dass es nochmal richtig gefixed wird. Sehe den Punkt mit dem fix für den build.

@FFHener FFHener mentioned this pull request Nov 20, 2024
@FFHener FFHener merged commit b2db94d into freifunk-berlin:main Nov 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants