-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corerouter: use patched version of bird2 and add proper inbound metrics #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noki
previously requested changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me even without the requested changes.
spolack
force-pushed
the
babel_metrics
branch
from
November 22, 2024 20:26
476ca01
to
f50b52c
Compare
PolynomialDivision
approved these changes
Nov 22, 2024
oh wait, please add something to commit message |
Please add to the commit message for reference
|
PolynomialDivision
pushed a commit
that referenced
this pull request
Nov 22, 2024
Switch to using a patched version of the BIRD daemon (`bird2-babelpatch`) maintained in our own repository. This version includes modifications to the Babel protocol, allowing route filtering based on specific interfaces and neighbors, while exporting all Babel routes to BIRD's core for enhanced flexibility. Link: https://bird.network.cz/pipermail/bird-users/2023-February/016705.html Link: #1087
PolynomialDivision
force-pushed
the
babel_metrics
branch
from
November 22, 2024 21:17
f50b52c
to
e1ceeee
Compare
Noki
approved these changes
Nov 23, 2024
Switch to using a patched version of the BIRD daemon (`bird2-babelpatch`) maintained in our own repository. This version includes modifications to the Babel protocol, allowing route filtering based on specific interfaces and neighbors, while exporting all Babel routes to BIRD's core for enhanced flexibility. Link: https://bird.network.cz/pipermail/bird-users/2023-February/016705.html Link: #1087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please test