Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corerouter: use patched version of bird2 and add proper inbound metrics #1087

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

spolack
Copy link
Member

@spolack spolack commented Nov 22, 2024

please test

@spolack spolack requested a review from Noki November 22, 2024 16:53
Noki
Noki previously requested changes Nov 22, 2024
Copy link
Member

@Noki Noki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me even without the requested changes.

roles/cfg_openwrt/templates/corerouter/bird.conf.j2 Outdated Show resolved Hide resolved
@PolynomialDivision
Copy link
Contributor

oh wait, please add something to commit message

@PolynomialDivision
Copy link
Contributor

PolynomialDivision commented Nov 22, 2024

Please add to the commit message for reference

Link: https://bird.network.cz/pipermail/bird-users/2023-February/016705.html

PolynomialDivision pushed a commit that referenced this pull request Nov 22, 2024
Switch to using a patched version of the BIRD daemon (`bird2-babelpatch`)
maintained in our own repository. This version includes modifications to the
Babel protocol, allowing route filtering based on specific interfaces and
neighbors, while exporting all Babel routes to BIRD's core for enhanced
flexibility.

Link: https://bird.network.cz/pipermail/bird-users/2023-February/016705.html
Link: #1087
@Noki Noki dismissed their stale review November 23, 2024 06:58

changed it with an additional commit

Switch to using a patched version of the BIRD daemon (`bird2-babelpatch`)
maintained in our own repository. This version includes modifications to the
Babel protocol, allowing route filtering based on specific interfaces and
neighbors, while exporting all Babel routes to BIRD's core for enhanced
flexibility.

Link: https://bird.network.cz/pipermail/bird-users/2023-February/016705.html
Link: #1087
@PolynomialDivision PolynomialDivision merged commit a53f121 into main Nov 23, 2024
11 checks passed
@PolynomialDivision PolynomialDivision deleted the babel_metrics branch November 23, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants