forked from coinbase/mesh-specifications
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle up #3
Open
restyled-io
wants to merge
60
commits into
master
Choose a base branch
from
restyled/pull-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Restyle up #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Construction API (formerly Wallet API)
restyled-io
bot
force-pushed
the
restyled/pull-2
branch
from
July 20, 2020 21:57
59f7f93
to
14656cd
Compare
This adds a requirement that all calls to the /block endpoint be idempotent when identifying a block by hash. This ensures blocks are inalterable and clients can safely assume that once they've received a specific block from a Rosetta implementation that block won't change.
Add /block idempotency requirement
restyled-io
bot
force-pushed
the
restyled/pull-2
branch
from
July 23, 2020 22:04
14656cd
to
459b197
Compare
TransactionIdentifierResponse + change default status to 500
restyled-io
bot
force-pushed
the
restyled/pull-2
branch
from
July 25, 2020 20:23
459b197
to
c303483
Compare
restyled-io
bot
force-pushed
the
restyled/pull-2
branch
from
July 25, 2020 23:50
c303483
to
5fede5a
Compare
Support Pre-Query Status
restyled-io
bot
force-pushed
the
restyled/pull-2
branch
from
July 26, 2020 00:14
5fede5a
to
5179719
Compare
…tion-pagination Improve `/block/transaction` description regarding pagination
restyled-io
bot
force-pushed
the
restyled/pull-2
branch
from
July 29, 2020 23:33
5179719
to
05f7f41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #2 with additional commits that automatically address
incorrect style, created by Restyled.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.