Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps and fix warnings #29

Merged
merged 2 commits into from
Oct 28, 2024
Merged

update deps and fix warnings #29

merged 2 commits into from
Oct 28, 2024

Conversation

shannonwells
Copy link
Contributor

@shannonwells shannonwells commented Oct 26, 2024

Description

Updates a bunch of packages including Svelte 5, and other major versions. Fixes some warnings.

Type of change

  • CI/Dependencies/etc...

How to Test?

Click on the latest preview deployment link, below.

  1. Verify it runs/doesn't crash, doesn't have warnings
  2. Click through the numerical slides and verify they all work
  3. Click the right side tab and make sure that shows up
  4. click around elsewhere

Checklist:

  • I have performed a self-review of my code
  • I have checked at all the breakpoints to make sure it works on all screen sizes

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/29/
Commit: 14504df

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/29/
Commit: b77f83a

@shannonwells shannonwells marked this pull request as ready for review October 26, 2024 00:20
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this works and looks good.

Question: Are there not other changes we needed to make for Svelte v5? I guess they aren't required based on the style guide, but perhaps we need an issue to remember to go back and update everything?

@shannonwells
Copy link
Contributor Author

shannonwells commented Oct 28, 2024

Question: Are there not other changes we needed to make for Svelte v5? I guess they aren't required based on the style guide, but perhaps we need an issue to remember to go back and update everything?

While their migration script didn't work, they also said most projects can upgrade and just fix errors and warnings. I looked over some of the migration notes for Svelte5, and this repo wasn't really using anything that was affected by the breaking changes (e.g. svelte:component is now svelte:element). I fixed all of the warnings and errors.

@wilwade
Copy link
Collaborator

wilwade commented Oct 28, 2024

@shannonwells Sounds good. Merge it!

@shannonwells shannonwells merged commit 2f54c7a into main Oct 28, 2024
7 checks passed
@shannonwells shannonwells deleted the update-dependencies-#28 branch October 28, 2024 17:22
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Dependency Updates
2 participants