-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update deps and fix warnings #29
Conversation
🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content. Preview URL: https://www.frequency.xyz/_pr/29/ |
🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content. Preview URL: https://www.frequency.xyz/_pr/29/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this works and looks good.
Question: Are there not other changes we needed to make for Svelte v5? I guess they aren't required based on the style guide, but perhaps we need an issue to remember to go back and update everything?
While their migration script didn't work, they also said most projects can upgrade and just fix errors and warnings. I looked over some of the migration notes for Svelte5, and this repo wasn't really using anything that was affected by the breaking changes (e.g. svelte:component is now svelte:element). I fixed all of the warnings and errors. |
@shannonwells Sounds good. Merge it! |
Description
Updates a bunch of packages including Svelte 5, and other major versions. Fixes some warnings.
Type of change
How to Test?
Click on the latest preview deployment link, below.
Checklist: